Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multi-models in borwein #701

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

multi-models in borwein #701

wants to merge 3 commits into from
+759 −133

Conversation

csfldf
Copy link
Collaborator

@csfldf csfldf commented Sep 29, 2024

  1. support multi-models in borwein
  2. add cpu usage ratio for pod and node custom metrics

@csfldf csfldf added the enhancement New feature or request label Sep 29, 2024
@csfldf csfldf self-assigned this Sep 29, 2024
@csfldf csfldf force-pushed the dev/multi_models branch 3 times, most recently from b808189 to 3f931e7 Compare September 29, 2024 08:04
@codecov Codecov
Copy link

codecov bot commented Sep 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 51.16279% with 126 lines in your changes missing coverage. Please review.

Project coverage is 57.10%. Comparing base (f6623f4) to head (320ae3b).

Files with missing lines Patch % Lines
...ce/models/borwein/inferencesvc/inference_svc.pb.go 8.82% 58 Missing and 4 partials ⚠️
...in/inference/modelresultfetcher/borwein/borwein.go 39.24% 38 Missing and 10 partials ⚠️
...in/trainingtpreg/training_throughput_regression.go 73.07% 5 Missing and 2 partials ⚠️
.../agent/metric/provisioner/malachite/provisioner.go 82.85% 4 Missing and 2 partials ⚠️
...tions/sysadvisor/qosaware/model/borwein/borwein.go 57.14% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #701      +/-   ##
==========================================
- Coverage   57.14%   57.10%   -0.04%     
==========================================
  Files         568      571       +3     
  Lines       54981    55205     +224     
==========================================
+ Hits        31419    31527     +108     
- Misses      19625    19718      +93     
- Partials     3937     3960      +23
Flag Coverage Δ
unittest 57.10% <51.16%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@csfldf csfldf force-pushed the dev/multi_models branch 4 times, most recently from 8c8915e to feeafcd Compare September 29, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sun-yuliang sun-yuliang Awaiting requested review from sun-yuliang

@gary-lgy gary-lgy Awaiting requested review from gary-lgy gary-lgy is a code owner

@luomingmeng luomingmeng Awaiting requested review from luomingmeng luomingmeng is a code owner

@nightmeng nightmeng Awaiting requested review from nightmeng nightmeng is a code owner

@xu282934741 xu282934741 Awaiting requested review from xu282934741 xu282934741 is a code owner

@waynepeking348 waynepeking348 Awaiting requested review from waynepeking348 waynepeking348 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@csfldf csfldf

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csfldf @sun-yuliang